Conversation
insertish
reviewed
Mar 19, 2026
Member
There was a problem hiding this comment.
Logging should be implemented, here is a general overview of how restic-api's logging works:
- The only logs produced are per-request structured logs, with all context injected
- Errors, auth, request timings, path, parameters, etc. are all added either in the interceptor (https://github.com/immich-app/yucca/blob/main/packages/common/server/src/otel/logging.interceptor.ts) or to the per-request context (https://github.com/immich-app/yucca/blob/main/packages/common/server/src/otel/wideContext.repository.ts)
- All error events are stored but all others are sampled
- Implementation inspired by https://loggingsucks.com/
Author
There was a problem hiding this comment.
It does deserve some love, which I'll do.
As far as sampling, that's typically done on the ingestion side.
Member
There was a problem hiding this comment.
Hmm, I wasn't seeing any output in either the terminal (do I need to set an environment variable?) or in VictoriaLogs (I didn't see anything pointing at VL either).
Member
Author
There was a problem hiding this comment.
This is on me saying "ehh probably works" and not testing it. Sorry bout' that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Michael; self-explanatory from the name.
RESTIC_BACKEND=michael mise run e2emain